This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb] s390-vregs.exp: Fix Tcl error after non-zero-pad patch
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Mon, 24 Jul 2017 12:59:45 -0400
- Subject: [binutils-gdb] s390-vregs.exp: Fix Tcl error after non-zero-pad patch
- Authentication-results: sourceware.org; auth=none
*** TEST RESULTS FOR COMMIT 031ed05dd2756557c3f5cda6690a9f3220918ffb ***
Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 031ed05dd2756557c3f5cda6690a9f3220918ffb
s390-vregs.exp: Fix Tcl error after non-zero-pad patch
s390-vregs.exp yields a Tcl error:
ERROR: can't read "i": no such variable
while executing
"expr $a_high * ($i + 1) * $a_high "
(procedure "hex128" line 2)
invoked from within
"hex128 $a_high $a_low $b_high $b_low"
...
This is a regression, caused by commit 30a254669b16b8 -- "Don't always
zero pad in print_*_chars". That patch introduced a new procedure
"hex128" for formatting a 128-bit value as hex, but it accidentally moved
the calculation of the 128-bit value into that new procedure as well
instead of leaving it in the original context. This is fixed.
gdb/testsuite/ChangeLog:
* gdb.arch/s390-vregs.exp: Calculate parameters to hex128 in the
calling context.
(hex128): Drop erroneous calculation of parameters.