This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb] write_pieced_value: Transfer least significant bits into bit-field
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Tue, 13 Jun 2017 14:07:39 -0400
- Subject: [binutils-gdb] write_pieced_value: Transfer least significant bits into bit-field
- Authentication-results: sourceware.org; auth=none
*** TEST RESULTS FOR COMMIT 359b19bb24d048750aa5367ad56a33267300d1a8 ***
Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: 359b19bb24d048750aa5367ad56a33267300d1a8
write_pieced_value: Transfer least significant bits into bit-field
On big-endian targets, when targeting a bit-field, write_pieced_value
currently transfers the source value's *most* significant bits to the
target value, instead of its least significant bits. This is fixed.
In particular the fix adjusts the initial value of 'offset', which can now
potentially be nonzero. Thus the variable 'type_len' is renamed to
'max_offset', to avoid confusion. And for consistency, the affected logic
that was mirrored in read_pieced_value is changed there in the same way.
gdb/ChangeLog:
* dwarf2loc.c (write_pieced_value): When writing to a bit-field,
transfer the source value's least significant bits, instead of its
lowest-addressed ones. Rename type_len to max_offset.
(read_pieced_value): Mirror above changes to write_pieced_value as
applicable.