This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb] BFD: Fix double BFD_FAIL calls in `bfd_default_reloc_type_lookup'
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Tue, 01 Nov 2016 19:07:17 -0400
- Subject: [binutils-gdb] BFD: Fix double BFD_FAIL calls in `bfd_default_reloc_type_lookup'
- Authentication-results: sourceware.org; auth=none
*** TEST RESULTS FOR COMMIT af955fe696088e69b436947b4a6f134567d31793 ***
Author: Maciej W. Rozycki <macro@imgtec.com>
Branch: master
Commit: af955fe696088e69b436947b4a6f134567d31793
BFD: Fix double BFD_FAIL calls in `bfd_default_reloc_type_lookup'
Break out of the outer switch statement once the inner switch for the
BFD_RELOC_CTOR relocation has been processed, preventing double BFD_FAIL
calls from being made, once from the inner switch and then again from
the default case of the outer switch.
Noticed with a `-Wimplicit-fallthrough' build error reported by a recent
GCC version:
In file included from .../bfd/reloc.c:52:0:
.../bfd/reloc.c: In function 'bfd_default_reloc_type_lookup':
.../bfd/libbfd.h:779:8: error: this statement may fall through [-Werror=implicit-fallthrough=]
do { bfd_assert(__FILE__,__LINE__); } while (0)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../bfd/reloc.c:7780:4: note: in expansion of macro 'BFD_FAIL'
BFD_FAIL ();
^~~~~~~~
.../bfd/reloc.c:7782:5: note: here
default:
^~~~~~~
cc1: all warnings being treated as errors
make[4]: *** [reloc.lo] Error 1
bfd/
* reloc.c (bfd_default_reloc_type_lookup) <BFD_RELOC_CTOR>: Do
not fall through to the default case.
- Follow-Ups:
- *** COMPILATION FAILED *** Failures on Fedora-i686, branch master *** BREAKAGE ***
- *** COMPILATION FAILED *** Failures on Debian-i686-native-extended-gdbserver, branch master *** BREAKAGE ***
- Failures on Fedora-x86_64-native-gdbserver-m32, branch master
- *** COMPILATION FAILED *** Failures on Debian-i686, branch master *** BREAKAGE ***
- Failures on Ubuntu-AArch64-native-gdbserver-m64, branch master
- Failures on Debian-s390x-native-extended-gdbserver-m64, branch master
- Failures on Debian-x86_64-native-extended-gdbserver-m64, branch master
- Failures on Debian-s390x-native-gdbserver-m64, branch master
- Failures on Fedora-ppc64be-native-gdbserver-m64, branch master
- Failures on Fedora-ppc64be-native-extended-gdbserver-m64, branch master
- Failures on Fedora-ppc64le-native-gdbserver-m64, branch master
- Failures on Fedora-ppc64le-native-extended-gdbserver-m64, branch master