This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb] infcmd, btrace: fix crash in 'finish' for tailcall-only frames
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Wed, 01 Jun 2016 05:25:19 -0400
- Subject: [binutils-gdb] infcmd, btrace: fix crash in 'finish' for tailcall-only frames
- Authentication-results: sourceware.org; auth=none
*** TEST RESULTS FOR COMMIT e3b5daf9f735999259c5a8f68b422850c59897e5 ***
Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: e3b5daf9f735999259c5a8f68b422850c59897e5
infcmd, btrace: fix crash in 'finish' for tailcall-only frames
Patch 7eb895307f53 Skip unwritable frames in command "finish"
skips non-writable frames in addition to tailcall frames.
If skip_tailcall_frames already returns NULL, skip_unwritable_frames
will be called with a NULL frame and crash in get_frame_arch. This is
caught by gdb.btrace/tailcall-only.exp.
Further, if we ever end up with a mixture of tailcall and non-writable
frames, we may not skip all of them, as intended.
Loop over skip_tailcall_frames and skip_unwritable_frames as long as at least
one of them makes progress.
gdb/
* infcmd.c (skip_finish_frames): New.
(finish_command): Call skip_finish_frames.
- Follow-Ups:
- *** COMPILATION FAILED *** Failures on AIX-POWER7-plain, branch master *** BREAKAGE ***
- Failures on Fedora-ppc64be-cc-with-index, branch master
- Failures on Fedora-i686, branch master
- Failures on Fedora-ppc64be-m64, branch master
- Failures on Fedora-ppc64le-cc-with-index, branch master
- Failures on Debian-i686-native-extended-gdbserver, branch master
- Failures on Fedora-ppc64be-native-gdbserver-m64, branch master
- Failures on Fedora-ppc64le-native-gdbserver-m64, branch master
- Failures on Fedora-ppc64be-native-extended-gdbserver-m64, branch master
- Failures on Debian-i686, branch master
- Failures on Fedora-ppc64le-m64, branch master
- Failures on Fedora-x86_64-m64, branch master
- Failures on Debian-x86_64-m64, branch master
- Failures on Fedora-s390x-m64, branch master
- Failures on Debian-x86_64-native-extended-gdbserver-m64, branch master