This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb] c_value_print: Revert 'val' to a reference for TYPE_CODE_STRUCT
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Wed, 27 Apr 2016 11:33:48 -0400
- Subject: [binutils-gdb] c_value_print: Revert 'val' to a reference for TYPE_CODE_STRUCT
- Authentication-results: sourceware.org; auth=none
*** TEST RESULTS FOR COMMIT 476350ba4800f1144b125f6511a5e25b223cc90b ***
Author: Martin Galvan <martin.galvan@tallertechnologies.com>
Branch: master
Commit: 476350ba4800f1144b125f6511a5e25b223cc90b
c_value_print: Revert 'val' to a reference for TYPE_CODE_STRUCT
Currently c_value_print will turn struct reference values into pointers before
doing a set of RTTI checks. This was introduced as a fix to PR c++/15401.
If there's RTTI the pointer will be adjusted and converted back to a reference.
However, if there's no RTTI the value will still be treated as a pointer during
the remainder of the function.
This patch moves the conversion down so that it's always performed when needed.
Notice this currently has not user-visible effects, so can be seen as a small
code cleanup. However, it'll be necessary for the bug-fix for handling
synthetic C++ references. It causes no testsuite regressions.
gdb/ChangeLog:
2016-04-26 Martin Galvan <martin.galvan@tallertechnologies.com>
* c-valprint.c (c_value_print): Always convert val back to reference
type if we converted it to a pointer type.
- Follow-Ups:
- Failures on Fedora-x86_64-native-gdbserver-m64, branch master
- Failures on Debian-i686, branch master
- Failures on AIX-POWER7-plain, branch master
- Failures on Fedora-x86_64-native-gdbserver-m32, branch master
- Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master
- Failures on Fedora-ppc64be-native-gdbserver-m64, branch master
- Failures on Fedora-ppc64be-native-extended-gdbserver-m64, branch master
- Failures on Debian-x86_64-native-extended-gdbserver-m64, branch master
- Failures on Fedora-ppc64le-native-extended-gdbserver-m64, branch master
- Failures on Fedora-ppc64le-native-gdbserver-m64, branch master