This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb/gdb-7.11-branch] Fix PR gdb/19676: Internal error in linux-thread.db.c if /proc not mounted
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Tue, 15 Mar 2016 13:33:58 -0400
- Subject: [binutils-gdb/gdb-7.11-branch] Fix PR gdb/19676: Internal error in linux-thread.db.c if /proc not mounted
- Authentication-results: sourceware.org; auth=none
*** TEST RESULTS FOR COMMIT 9312893c8d63934f7855451c6a78503e69a47453 ***
Author: Pedro Alves <palves@redhat.com>
Branch: gdb-7.11-branch
Commit: 9312893c8d63934f7855451c6a78503e69a47453
Fix PR gdb/19676: Internal error in linux-thread.db.c if /proc not mounted
If /proc is not mounted, GDB fails an assertion in find_new_threads_once:
Continuing.
.../src/gdb/linux-thread-db.c:1249: internal-error: find_new_threads_once: Assertion `!target_has_execution' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n)
That was supposed to catch misuses of td_ta_thr_iter, which is unsafe
for live debugging. However, if /proc is not mounted, we still
fallback to using it.
I didn't bother with a warning, because GDB already prints several
others related to failing to open /proc files.
gdb/ChangeLog:
2016-03-15 Pedro Alves <palves@redhat.com>
PR gdb/19676
* linux-thread-db.c (try_thread_db_load_1): Leave
info->td_ta_thr_iter_p NULL iff debugging a live process and we
have /proc access.
(find_new_threads_once): Assert that we have a non-NULL
info->td_ta_thr_iter_p instead of checking whether the target has
execution.
- Follow-Ups:
- Failures on RHEL-s390x-m64, branch gdb-7.11-branch
- Failures on AIX-POWER7-plain, branch gdb-7.11-branch
- Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch gdb-7.11-branch
- Failures on Debian-s390x-native-gdbserver-m64, branch gdb-7.11-branch
- Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch gdb-7.11-branch
- Failures on Fedora-x86_64-native-gdbserver-m64, branch gdb-7.11-branch
- Failures on Debian-s390x-native-extended-gdbserver-m64, branch gdb-7.11-branch
- Failures on Debian-i686, branch gdb-7.11-branch
- Failures on Debian-i686-native-gdbserver, branch gdb-7.11-branch
- Failures on Debian-i686-native-extended-gdbserver, branch gdb-7.11-branch
- Failures on Fedora-ppc64be-native-gdbserver-m64, branch gdb-7.11-branch
- Failures on Debian-x86_64-native-extended-gdbserver-m64, branch gdb-7.11-branch
- Failures on Fedora-ppc64be-native-extended-gdbserver-m64, branch gdb-7.11-branch
- Failures on Fedora-ppc64le-native-extended-gdbserver-m64, branch gdb-7.11-branch
- Failures on Debian-x86_64-native-gdbserver-m64, branch gdb-7.11-branch