This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
Test results for commit 46d020960241fcafd7d0ab483746a206829620ea on branch gdb-7.9-branch
- From: sergiodj at redhat dot com
- To: gdb-testers at sourceware dot org
- Date: Wed, 11 Feb 2015 09:55:11 -0500
- Subject: Test results for commit 46d020960241fcafd7d0ab483746a206829620ea on branch gdb-7.9-branch
- Authentication-results: sourceware.org; auth=none
*** TEST RESULTS FOR COMMIT 46d020960241fcafd7d0ab483746a206829620ea ***
Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: gdb-7.9-branch
Commit: 46d020960241fcafd7d0ab483746a206829620ea
framefilter quit: Code cleanup: Avoid gotos
goto error patters are sometimes AFAIK used in C for the cases like:
int retval=-1;
if (!(a=malloc())) goto error;
if (!(b=malloc())) goto error_a;
if (!(c=malloc())) goto error_b;
retval=0;
error_c: free(c);
error_b: free(b);
error_a: free(a);
error: return retval;
But here there is single error label with one do_cleanups() which I do not find
it worth the goto complication. Without goto one can then furher merge code in
the exit paths in the next patches and ... after all it is all the same, just
without a goto.
gdb/ChangeLog
2015-02-11 Jan Kratochvil <jan.kratochvil@redhat.com>
* python/py-framefilter.c (py_print_frame): Substitute goto error.
Remove the error label.
- Follow-Ups:
- Failures on Fedora-ppc64le-native-extended-gdbserver-m64, branch gdb-7.9-branch
- Failures on Fedora-ppc64le-cc-with-index, branch gdb-7.9-branch
- Failures on Fedora-ppc64le-native-gdbserver-m64, branch gdb-7.9-branch
- Failures on Fedora-ppc64le-m64, branch gdb-7.9-branch
- Failures on Fedora-ppc64be-m64, branch gdb-7.9-branch
- Failures on Fedora-ppc64be-native-gdbserver-m64, branch gdb-7.9-branch
- Failures on Fedora-ppc64be-native-extended-gdbserver-m64, branch gdb-7.9-branch
- Failures on Fedora-x86_64-cc-with-index, branch gdb-7.9-branch
- Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch gdb-7.9-branch
- Failures on Fedora-x86_64-m64, branch gdb-7.9-branch
- Failures on Fedora-x86_64-native-gdbserver-m32, branch gdb-7.9-branch
- Failures on Fedora-x86_64-native-gdbserver-m64, branch gdb-7.9-branch
- Failures on Debian-i686, branch gdb-7.9-branch
- Failures on Debian-i686-native-gdbserver, branch gdb-7.9-branch
- Failures on Debian-i686-native-extended-gdbserver, branch gdb-7.9-branch
- Failures on Debian-x86_64-native-extended-gdbserver-m64, branch gdb-7.9-branch