[RFA] Escape curly braces (Re: Sunday Project gdb test results, 2001-10-28)

[Orjan Friberg <orjan dot friberg at axis dot com>]

Michael Elizabeth Chastain wrote:
> 
> gdb.base/setvar.exp:
> 
>   This script produces 2 ERRORs on native i686-pc-linux-gnu (red hat linux 7.1):
> 
>     set variable *(v_signed_short_pointer+1)=-456
>     (gdb) PASS: gdb.base/setvar.exp: set variable *(v_signed_short_pointer+1)=-456
>     ERROR: Process no longer exists
>     UNRESOLVED: gdb.base/setvar.exp: set variable signed short pointer
>     print v_signed_short_array
>     $83 = {123, -456}
> 
>     set variable *(v_unsigned_short_pointer+1)=-456
>     (gdb) PASS: gdb.base/setvar.exp: set variable *(v_unsigned_short_pointer+1)=-456
>     ERROR: Process no longer exists
>     UNRESOLVED: gdb.base/setvar.exp: set variable unsigned short pointer
>     print v_unsigned_short_array
>     $85 = {123, 65080}
>     (gdb) print *(v_unsigned_short_pointer+1)
>     $86 = 65080
> 
>   I have not analyzed these errors.
> 
> gdb.base/weird.exp:
> 
>   This script produces 2 ERRORs on native i686-pc-linux-gn (red hat linux 7.1):
> 
>     ptype bad_type1
>     type = <unknown type>
>     (gdb) PASS: gdb.stabs/weird.exp: print bad_type1
>     ERROR: Process no longer exists
>     UNRESOLVED: gdb.stabs/weird.exp: array0 with strange index
>     ERROR: Process no longer exists
>     UNRESOLVED: gdb.stabs/weird.exp: array1 with strange index
> 
>   I have not analyzed these errors.


I'm just grabbing some low-hanging fruit: these unresolved test cases
are due to unescaped left curly braces.  There have been a couple of
threads on the subject in the past.  (In printcmds.exp it's solved by a
wrapper function that does the escaping.)  Ok to commit?


2001-10-29  Orjan Friberg  <orjanf@axis.com>

        * testsuite/gdb.base/setvar.exp: Escape curly braces.
        * testsuite/gdb.stabs/weird.exp: Ditto.


Index: setvar.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/setvar.exp,v
retrieving revision 1.3
diff -u -r1.3 setvar.exp
--- setvar.exp  2001/03/06 08:21:51     1.3
+++ setvar.exp  2001/10/29 10:25:13
@@ -320,7 +320,7 @@
 gdb_test "set v_signed_short_pointer=v_signed_short_array" ""
 gdb_test "set variable *(v_signed_short_pointer)=123" ""
 gdb_test "set variable *(v_signed_short_pointer+1)=-456" ""
-gdb_test "print v_signed_short_array" ".\[0-9\]* =.*\{123,.*-456\}" \
+gdb_test "print v_signed_short_array" ".\[0-9\]* =.*\\{123,.*-456\\}" \
     "set variable signed short pointer"
 gdb_test "print *(v_signed_short_pointer+1)" ".\[0-9\]*.*=.*-456"
 #
@@ -331,7 +331,7 @@
 gdb_test "set variable *(v_unsigned_short_pointer+1)=-456" ""
 # DTS 10060CLLbs - bad type info from cc
 if {$hp_cc_compiler} {setup_xfail hppa*-*-*11* 10060CLLbs}
-gdb_test "print v_unsigned_short_array" ".\[0-9\]* =.*\{123,.*65080\}"
\
+gdb_test "print v_unsigned_short_array" ".\[0-9\]*
=.*\\{123,.*65080\\}" \
     "set variable unsigned short pointer"
 # DTS 10060CLLbs - bad type info from cc
 if {$hp_cc_compiler} {setup_xfail hppa*-*-*11* 10060CLLbs}


Index: weird.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.stabs/weird.exp,v
retrieving revision 1.3
diff -u -r1.3 weird.exp
--- weird.exp   2001/10/26 04:17:45     1.3
+++ weird.exp   2001/10/29 10:25:41
@@ -170,9 +170,9 @@
 
        # GDB does not yet support arrays indexed by anything at all
unusual
        setup_xfail "*-*-*"
-       gdb_test "p array0" " = \{42, 43, 44, 45, 46, 47\}" "array0 with
strange index"
+       gdb_test "p array0" " = \\{42, 43, 44, 45, 46, 47\\}" "array0
with strange index"
        setup_xfail "*-*-*"
-       gdb_test "p array1" " = \{42, 43, 44\}" "array1 with strange
index"
+       gdb_test "p array1" " = \\{42, 43, 44\\}" "array1 with strange
index"
 
        # GDB does not yet support this feature
        gdb_test "whatis one_var" "type = inttype_one" \


-- 
Orjan Friberg              E-mail: orjan.friberg@axis.com
Axis Communications AB     Phone:  +46 46 272 17 68