This is the mail archive of the gdb-prs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug gdb/13211] Async / Process group and interrupt not working


https://sourceware.org/bugzilla/show_bug.cgi?id=13211

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Pedro Alves <palves@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3045b47554503c6f154e446662204e295fc769a1

commit 3045b47554503c6f154e446662204e295fc769a1
Author: Pedro Alves <palves@redhat.com>
Date:   Wed Jan 31 13:50:34 2018 +0000

    gdb: Fix remote-sim/MinGW/Darwin builds

    (Add missing ChangeLog entry)

    The recent commit e671cd59 ("Per-inferior target_terminal state, fix
    PR gdb/13211, more") missed adjusting a few targets to the new
    target_ops->to_interrupt interface, breaking the build for those
    targets.  This fixes it.

    Note: remote-sim doesn't really support async execution, so I don't
    think gdbsim_interrupt is ever reached via target_interrupt.  (It is
    reached via gdbsim_cntrl_c though).

    The inflow.c changes are a bit ugly, but they're just doing what other
    parts of the file already do to handle the same missing functions.
    Targets that don't have 'kill', like mingw have their own
    target_ops->to_interrupt implementation, so it's fine to make
    child_interrupt be a nop.

    gdb/ChangeLog:
    2018-01-31  Pedro Alves  <palves@redhat.com>

        * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
        * inflow.c (child_terminal_save_inferior): Wrap reference to
        tcgetpgrp in HAVE_TERMIOS_H.
        (child_interrupt, child_pass_ctrlc): Wrap references to signal in
        _WIN32.
        * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
        always iterate over all inferiors.
        (gdbsim_cntrl_c): Adjust.
        * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]