This is the mail archive of the gdb-prs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug gdb/22557] Regression: gdb.base/dtrace-probe.exp


https://sourceware.org/bugzilla/show_bug.cgi?id=22557

--- Comment #6 from Sergio Durigan Junior <sergiodj at redhat dot com> ---
(In reply to Pedro Alves from comment #5)
> (In reply to Sergio Durigan Junior from comment #3)
> > The test is failing for me even before the C++-ification patch, which
> > excludes the possibility of a regression introduced by the series.
> 
> That's not a good assumption to make because it was failing for you for
> other reasons.  It was clearly passing for me, as shown in the log in the OP.
> I've now confirmed it: the test was passing at
> 935676c92feb5f35e4634ef58c20ffdfd0979b07^ (before "Convert generic probe
> interface to C++ (and perform some cleanups)"), and started failing at
> 9c23b42ffa67b866cd7562c1d8caed70db5d6840 ("Convert DTrace probe interface to
> C++ (and perform some cleanups)").

I did not see the log you mentioned.  I agree that my conclusion was
precipitated, but comment 1 says

  I suspect this is more fall out from the probe C++ification.  (Just a guess,
I'm not really looking at it.)

So it wasn't clear to me whether the test was passing before or not.

Anyway, just explaining why I thought this regression had been introduced by an
older commit.

> > Unfortunately I cannot test things with the regular dtrace program, because
> > it is proprietary.  So it may very well be a problem with pdtrace.
> 
> TBC, I'm not using regular dtrace either.  The difference is that I observed
> the regression on F23, and pdtrace only gets broken with binutils newer than
> F23's.  If I test on F23 with current master binutils in the PATH, I also
> see the undefined references to `main'.

Right, and putting "-R .eh_frame -K main" in the ${STRIP} line doesn't work.

> (In reply to cvs-commit@gcc.gnu.org from comment #4)
> 
> > commit 92469284a650232768523564f2c715c4ebb57906
> > Author: Sergio Durigan Junior <sergiodj@redhat.com>
> > Date:   Fri Dec 8 15:33:55 2017 -0500
> > 
> >     Fix thinko on dtrace-probe.c:dtrace_process_dof_probe
> >     
> ...
> >     This commit fixes that.  Unfortunately the script used to test DTrace
> >     probes (gdb/testsuite/lib/pdtrace.in) is not very reliable so I cannot
> >     say whether this commit fixes the PR mentioned above.  Nonetheless,
> >     it's an obvious fix and should go in.
> 
> Yes, this fixed it for me.  Thanks.

Thanks for testing it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]