[Bug breakpoints/22511] Regression in "commands"

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=22511

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=99598d713f45d1b26015ec3562d160dc2b3792e4

commit 99598d713f45d1b26015ec3562d160dc2b3792e4
Author: Tom Tromey <tom@tromey.com>
Date:   Fri Nov 3 10:26:11 2017 -0600

    Fix regression in "commands"

    Pedro pointed out a regression in "commands", where trying to clear a
    breakpoint's command list would fail:

        (top-gdb) commands
        Type commands for breakpoint(s) 3, one per line.
        End with a line saying just "end".
        >end
        No breakpoints specified.
        (top-gdb)

    I believe the bug was introduced by my patch that changes
    counted_command_line to be a shared_ptr.  This causes the problem
    because now the counted_command_line in commands_command_1 can be NULL,
    whereas previously it never could be.

    After some discussion, we agreed to simply remove the error case from
    commands_command_1.

    2017-12-07  Tom Tromey  <tom@tromey.com>

        PR breakpoints/22511:
        * breakpoint.c (commands_command_1): Don't throw an exception when
        no commands have been read.

    2017-12-07  Tom Tromey  <tom@tromey.com>

        * gdb.base/break.exp: Add test for empty "commands".

-- 
You are receiving this mail because:
You are on the CC list for the bug.