[Bug tdep/20953] GDB crashes after "set architecture rl78"

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=20953

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The gdb-7.12-branch branch has been updated by Yao Qi <qiyao@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=68647b569da041a33a6504cd80f51fbd43bfa134

commit 68647b569da041a33a6504cd80f51fbd43bfa134
Author: Yao Qi <yao.qi@linaro.org>
Date:   Fri Dec 9 15:52:37 2016 +0000

    Create tdep->rl78_psw_type lazily

    I build GDB for all targets enabled.  When I "set architecture rl78",
    GDB crashes,

    (gdb) set architecture rl78

    Program received signal SIGSEGV, Segmentation fault.
    append_flags_type_flag (type=0x20cc0e0, bitpos=bitpos@entry=0,
name=name@entry=0x11dba3f "CY") at ../../binutils-gdb/gdb/gdbtypes.c:4926
    4926                               name);
    (gdb) bt 10
     #0  append_flags_type_flag (type=0x20cc0e0, bitpos=bitpos@entry=0,
name=name@entry=0x11dba3f "CY") at ../../binutils-gdb/gdb/gdbtypes.c:4926
     #1  0x00000000004aaca8 in rl78_gdbarch_init (info=..., arches=<optimized
out>) at ../../binutils-gdb/gdb/rl78-tdep.c:1410
     #2  0x00000000006b05a4 in gdbarch_find_by_info (info=...) at
../../binutils-gdb/gdb/gdbarch.c:5269
     #3  0x000000000060eee4 in gdbarch_update_p (info=...) at
../../binutils-gdb/gdb/arch-utils.c:557
     #4  0x000000000060f8a8 in set_architecture (ignore_args=<optimized out>,
from_tty=1, c=<optimized out>) at ../../binutils-gdb/gdb/arch-utils.c:531
     #5  0x0000000000593d0b in do_set_command (arg=<optimized out>,
arg@entry=0x20be851 "rl78", from_tty=from_tty@entry=1, c=c@entry=0x20b1540)
        at ../../binutils-gdb/gdb/cli/cli-setshow.c:455
     #6  0x00000000007665c3 in execute_command (p=<optimized out>,
p@entry=0x20be840 "set architecture rl78", from_tty=1) at
../../binutils-gdb/gdb/top.c:666
     #7  0x00000000006935f4 in command_handler (command=0x20be840 "set
architecture rl78") at ../../binutils-gdb/gdb/event-top.c:577
     #8  0x00000000006938d8 in command_line_handler (rl=<optimized out>) at
../../binutils-gdb/gdb/event-top.c:767
     #9  0x0000000000692c2c in gdb_rl_callback_handler (rl=0x20be890 "") at
../../binutils-gdb/gdb/event-top.c:200

    The cause is that we want to access some builtin types in gdbarch init, but
    it is not initialized yet.  I fix it by creating the type when it is to be
    used.  We've already done this in sparc, sparc64 and m68k.

    gdb:

    2016-12-09  Yao Qi  <yao.qi@linaro.org>

        PR tdep/20953
        * rl78-tdep.c (rl78_psw_type): New function.
        (rl78_register_type): Call rl78_psw_type.
        (rl78_gdbarch_init): Move code to rl78_psw_type.

-- 
You are receiving this mail because:
You are on the CC list for the bug.