[Bug gdb/17210] read_memory_robust can leak memory

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=17210

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9d78f827e0da9ab6fda2d6ef2d59cebb805b411f

commit 9d78f827e0da9ab6fda2d6ef2d59cebb805b411f
Author: Tom Tromey <tom@tromey.com>
Date:   Thu Jun 9 09:46:53 2016 -0600

    PR gdb/17210 - fix possible memory leak in read_memory_robust

    PR gdb/17210 concerns a possible memory leak in read_memory_robust.
    The bug can happen because read_memory_robust allocates memory, does
    not install any cleanups, and invokes QUIT.  Similarly, target_read
    calls QUIT, so it too can potentially throw.

    The fix is to install cleanups to guard the allocated memory.

    Built and regtested on x86-64 Fedora 23.  I couldn't think of a way to
    test this, so no new test; and of course this means it should have
    more careful review.

    2016-06-29  Tom Tromey  <tom@tromey.com>

        PR gdb/17210:
        * target.c (free_memory_read_result_vector): Take a pointer to the
        VEC as an argument.
        (read_memory_robust): Install a cleanup for "result".
        * mi/mi-main.c (mi_cmd_data_read_memory_bytes): Update.

-- 
You are receiving this mail because:
You are on the CC list for the bug.