[Bug remote/19840] gdb crashes on reverse-stepi

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=19840

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Pedro Alves <palves@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3a00c80277a54abe0b286a6e8babc8fe50120205

commit 3a00c80277a54abe0b286a6e8babc8fe50120205
Author: Pedro Alves <palves@redhat.com>
Date:   Wed Apr 13 14:34:00 2016 +0100

    Fix PR remote/19840: gdb crashes on reverse-stepi

    Reverse debugging against a remote target that does reverse debugging
    itself (with the bs/bc packets) always trips on:

     (gdb) target remote localhost:...
     (gdb) reverse-stepi
     ../../gdb/target.c:602: internal-error: default_execution_direction:
to_execution_direction must be implemented for reverse async

    I missed adding a to_execution_direction method to remote.c in commit
    3223143295b5 (Adds target_execution_direction to make record targets
    support async mode), GDB 7.4 time.  Later, GDB 7.8 switched to
    target-async on by default, making the regression user-visible by
    default too.

    Fix is simply to add the missing to_execution_direction implementation
    to target remote.

    Tested by Andi Kleen against Simics.

    gdb/ChangeLog:
    2016-04-13  Pedro Alves  <palves@redhat.com>

        PR remote/19840
        * remote.c (struct remote_state) <last_resume_exec_dir>: New
        field.
        (new_remote_state): Default last_resume_exec_dir to EXEC_FORWARD.
        (remote_open_1): Reset last_resume_exec_dir to EXEC_FORWARD.
        (remote_resume): Store the last execution direction.
        (remote_execution_direction): New function.
        (init_remote_ops): Install it as to_execution_direction target_ops
        method.

-- 
You are receiving this mail because:
You are on the CC list for the bug.