[Bug varobj/18564] regression in showing __thread so extern variable

["mjw at redhat dot com" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=18564

Mark Wielaard <mjw at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mjw at redhat dot com

--- Comment #2 from Mark Wielaard <mjw at redhat dot com> ---
2273f0ac95a79ce29ef42025c63f90e82cf907d7 is the first bad commit
commit 2273f0ac95a79ce29ef42025c63f90e82cf907d7
Author: Tom Tromey <tromey@redhat.com>
Date:   Tue Oct 15 13:28:57 2013 -0600

    change minsyms not to be relocated at read-time

    This removes the runtime offsets from minsyms.  Instead, these offsets
    will now be applied whenever the minsym's address is computed.

    This patch redefines MSYMBOL_VALUE_ADDRESS to actually use the offsets
    from the given objfile.  Then, it updates all the symbol readers,
    changing them so that they do not add in the section offset when
    creating the symbol.

    This change also lets us remove relocation of minsyms from
    objfile_relocate1 and also msymbols_sort.

    2014-02-26  Tom Tromey  <tromey@redhat.com>

        * minsyms.c (msymbols_sort): Remove.
        * minsyms.h (msymbols_sort): Remove.
        * objfiles.c (objfile_relocate1): Don't relocate minsyms.
        * symtab.h (MSYMBOL_VALUE_ADDRESS): Use objfile offsets.
        * elfread.c (elf_symtab_read): Don't add section offsets.
        * xcoffread.c (record_minimal_symbol): Don't add section offset
        to minimal symbol address.
        * somread.c (text_offset, data_offset): Remove.
        (som_symtab_read): Don't add section offsets to minimal symbol
        addresses.
        * coff-pe-read.c (add_pe_forwarded_sym, read_pe_exported_syms):
        Don't add section offsets to minimal symbols.
        * coffread.c (coff_symtab_read): Don't add section offsets
        to minimal symbol addresses.
        * machoread.c (macho_symtab_add_minsym): Don't add section offset
        to minimal symbol addresses.
        * mipsread.c (read_alphacoff_dynamic_symtab): Don't add
        section offset to minimal symbol addresses.
        * mdebugread.c (parse_partial_symbols): Don't add section
        offset to minimal symbol addresses.
        * dbxread.c (read_dbx_dynamic_symtab): Don't add section
        offset to minimal symbol addresses.

:040000 040000 f4063f5d4257ba2bc4a35d026cd3df4fe1f865b8
deb71e85a8c10482fb81add9a4adb319b2198acb M      gdb
bisect run success

-- 
You are receiving this mail because:
You are on the CC list for the bug.