This is the mail archive of the gdb-prs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug exp/18617] Incorrect expression bytecode generated for narrowing conversions


https://sourceware.org/bugzilla/show_bug.cgi?id=18617

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Pedro Alves <palves@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=bcf5c1d96b3b5493041002eb2b6d27288d9d160a

commit bcf5c1d96b3b5493041002eb2b6d27288d9d160a
Author: Robert O'Callahan <robert@ocallahan.org>
Date:   Wed Jul 8 10:53:36 2015 +0100

    PR18617 - Incorrect expression bytecode generated for narrowing conversions

    The existing code preserves 'from' bits, which is incorrect.  E.g.

     (gdb) maint agent-eval (char)255L
     Scope: 0x4008d6
     Reg mask: 00
       0  const16 255
       3  ext 64
       5  end

    'ext 64' should be 'ext 8'; this bytecode evaluates to 255 instead of
    the correct result of -1.  The fix is simple.  I ran the entire test
    suite on x86-64 and there were no new test failures.

    gdb/ChangeLog:
    2015-07-08  Robert O'Callahan  <robert@ocallahan.org>

        PR exp/18617
        * ax-gdb.c (gen_conversion): Extend to 'to' bits, not 'from'.

    gdb/testsuite/ChangeLog:
    2015-07-08  Robert O'Callahan  <robert@ocallahan.org>

        PR exp/18617
        * gdb.trace/ax.exp: Add test.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]