This is the mail archive of the gdb-prs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug python/17314] Any thread created by Python must block SIGCHLD


https://sourceware.org/bugzilla/show_bug.cgi?id=17314

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".

The branch, master has been updated
       via  3714cea7d44e2bd9cac28a61d45fcc8c3cc6ae83 (commit)
      from  1a8bdf69e7d1f6084af503407d6a4217b06d6ea5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3714cea7d44e2bd9cac28a61d45fcc8c3cc6ae83

commit 3714cea7d44e2bd9cac28a61d45fcc8c3cc6ae83
Author: Doug Evans <xdje42@gmail.com>
Date:   Sat Sep 13 15:52:15 2014 -0700

    Pass plain-text prompt to with_gdb_prompt.

    I had occasion to use with_gdb_prompt in a test for the patch for PR 17314
    and was passing the plain text prompt as the value, "(top-gdb)",
    instead of a regexp, "\(top-gdb\)" (expressed as "\\(top-gdb\\)" in TCL).

    I then discovered that in order to restore the prompt gdb passes the
    original value of $gdb_prompt to "set prompt", which works because
    "set prompt \(gdb\) " is equivalent to "set prompt (gdb) ".
    Perhaps I'm being overly cautious but this feels a bit subtle,
    but at any rate as an API choice I'd much rather pass the plain text
    form to with_gdb_prompt.

    I also discovered that the initial value of gdb_prompt is set in
    two places to two different values.
    At the global level gdb.exp sets it to "\[(\]gdb\[)\]"
    and default_gdb_init sets it to "\\(gdb\\)".
    The former form is undesirable as an argument to "set prompt",
    but it's not clear to me that just deleting this code won't break
    anything.  Thus I just changed the value to be consistent and added
    a comment.

    gdb/testsuite/ChangeLog:

        * lib/gdb.exp (gdb_prompt): Add comment and change initial value to
        be consistent with what default_gdb_init uses.
        (with_gdb_prompt): Change form of PROMPT argument from a regexp to
        the plain text of the prompt.  Add some logging printfs.
        * gdb.perf/disassemble.exp: Update call to with_gdb_prompt.

-----------------------------------------------------------------------

Summary of changes:
 gdb/testsuite/ChangeLog                |    8 ++++++++
 gdb/testsuite/gdb.perf/disassemble.exp |    2 +-
 gdb/testsuite/lib/gdb.exp              |   31 +++++++++++++++++++++++++++++--
 3 files changed, 38 insertions(+), 3 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]