[Bug breakpoints/16508] "-trace-find frame-number" does not work if trace file was taken while trace was running

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=16508

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".

The branch, master has been updated
       via  cc3da688013b5fb3dcc1fa5206bbeef4a35cc10c (commit)
      from  6a5f844b29319793deb3840b20803bd3a0fa01a2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=cc3da688013b5fb3dcc1fa5206bbeef4a35cc10c

commit cc3da688013b5fb3dcc1fa5206bbeef4a35cc10c
Author: Yao Qi <yao@codesourcery.com>
Date:   Sat Feb 15 08:48:53 2014 +0800

    Fix PR16508

    This patch fixes PR16508, which is about MI "-trace-find frame-number 0"
    behaves differently from CLI "tfind 0".  In CLI, we check both
    status->running and status->filename, but in MI, we only check
    status->running, which looks wrong to me.  This patch moves the code
    of checking to a new function check_trace_running, and use it in
    both CLI and MI.

    This patch also adds a test case pr16508.exp, which fails without this
    fix, and passes with the fix applied.

      FAIL: gdb.trace/pr16508.exp: interpreter-exec mi "-trace-find
frame-number 0"

    gdb:

    2014-03-06  Yao Qi  <yao@codesourcery.com>

        PR breakpoints/16508
        * tracepoint.c (check_trace_running): New function.
        (trace_find_command): Move code to check_trace_running and
        call check_trace_running.
        (trace_find_pc_command): Likewise.
        (trace_find_tracepoint_command): Likewise.
        (trace_find_line_command): Likewise.
        (trace_find_range_command): Likewise.
        * tracepoint.h (check_trace_running): Likewise.
        * mi/mi-main.c (mi_cmd_trace_find): Call check_trace_running.

    gdb/testsuite:

    2014-03-06  Yao Qi  <yao@codesourcery.com>

        * gdb.trace/pr16508.exp: New file.

-----------------------------------------------------------------------

Summary of changes:
 gdb/ChangeLog                       |   13 +++++++
 gdb/mi/mi-main.c                    |    3 +-
 gdb/testsuite/ChangeLog             |    4 ++
 gdb/testsuite/gdb.trace/pr16508.exp |   63 +++++++++++++++++++++++++++++++++++
 gdb/tracepoint.c                    |   29 ++++++++--------
 gdb/tracepoint.h                    |    2 +
 6 files changed, 97 insertions(+), 17 deletions(-)
 create mode 100644 gdb/testsuite/gdb.trace/pr16508.exp

-- 
You are receiving this mail because:
You are on the CC list for the bug.