[Bug testsuite/15992] New: Invalid check of reboot_target return value in testsuite/config/monitor.exp

["akolesov at synopsys dot com" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=15992

            Bug ID: 15992
           Summary: Invalid check of reboot_target return value in
                    testsuite/config/monitor.exp
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
          Assignee: unassigned at sourceware dot org
          Reporter: akolesov at synopsys dot com
                CC: jeremy.bennett at embecosm dot com

Created attachment 7222
  --> https://sourceware.org/bugzilla/attachment.cgi?id=7222&action=edit
Suggested patch

In gdb/testsuite/config/monitor.exp there are two conditions like: 

if { ![reboot_target] }

However reboot_target returns an empty string on success and operation ! is not
allowed an empty string, TCL doesn't treat it implicitly as a "false". If I
understand everything properly then ![reboot_target] should be replaced with
[reboot_target] == "".

I've attached a suggested patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.