Re: gdb/715: patch to avoid prototype conflict with readline 4.3

[Martin MOKREJŠ <mmokrejs at natur dot cuni dot cz>]

The following reply was made to PR gdb/715; it has been noted by GNATS.

From: =?iso-8859-2?Q?Martin_MOKREJ=A9?= <mmokrejs@natur.cuni.cz>
To: Petter Reinholdtsen <pere@hungry.com>
Cc: gdb-gnats@sources.redhat.com
Subject: Re: gdb/715: patch to avoid prototype conflict with readline 4.3 
Date: Tue, 3 Dec 2002 12:59:22 +0100 (CET)

 On Tue, 3 Dec 2002, Petter Reinholdtsen wrote:
 
 Hi,
   thanks for the note. Unfortunately, when I try to build, I gete even
 before that another error on Solaris 2.6:
 
 make[1]: Entering directory `/scratch/mmokrejs/gdb-5.2.1/libiberty'
 if [ x"" != x ]; then \
   gcc -c -DHAVE_CONFIG_H -I/software/@sys/usr/include -I/software/@sys/usr/include/ncurses -I/software/@sys/usr/openssl/include -I/software/@sys/usr/include/freetype2 -I. -I./../include  -W -Wall -Wtraditional -pedantic  concat.c -o pic/concat.o; \
 else true; fi
 gcc -c -DHAVE_CONFIG_H -I/software/@sys/usr/include -I/software/@sys/usr/include/ncurses -I/software/@sys/usr/openssl/include -I/software/@sys/usr/include/freetype2 -I. -I./../include  -W -Wall -Wtraditional -pedantic concat.c
 concat.c: In function `concat_length':
 concat.c:115: warning: implicit declaration of function `VA_OPEN'
 concat.c:115: `args' undeclared (first use in this function)
 concat.c:115: (Each undeclared identifier is reported only once
 concat.c:115: for each function it appears in.)
 concat.c:116: warning: implicit declaration of function `VA_FIXEDARG'
 concat.c:116: parse error before "const"
 concat.c:118: warning: implicit declaration of function `VA_CLOSE'
 concat.c: In function `concat_copy':
 concat.c:130: warning: function `VA_OPEN' was previously declared within a block
 concat.c:130: `args' undeclared (first use in this function)
 concat.c:131: warning: function `VA_FIXEDARG' was previously declared within a block
 concat.c:131: parse error before "char"
 concat.c:132: parse error before "const"
 concat.c:135: warning: function `VA_CLOSE' was previously declared within a block
 concat.c: In function `concat_copy2':
 concat.c:147: warning: function `VA_OPEN' was previously declared within a block
 concat.c:147: `args' undeclared (first use in this function)
 concat.c:148: warning: function `VA_FIXEDARG' was previously declared within a block
 concat.c:148: parse error before "const"
 concat.c:150: warning: function `VA_CLOSE' was previously declared within a block
 concat.c: In function `concat':
 concat.c:161: warning: function `VA_OPEN' was previously declared within a block
 concat.c:161: `args' undeclared (first use in this function)
 concat.c:162: warning: function `VA_FIXEDARG' was previously declared within a block
 concat.c:162: parse error before "const"
 concat.c:164: warning: function `VA_CLOSE' was previously declared within a block
 concat.c:168: parse error before "const"
 concat.c: In function `reconcat':
 concat.c:198: warning: function `VA_OPEN' was previously declared within a block
 concat.c:198: `args' undeclared (first use in this function)
 concat.c:199: warning: function `VA_FIXEDARG' was previously declared within a block
 concat.c:199: parse error before "char"
 concat.c:200: parse error before "const"
 concat.c:202: warning: function `VA_CLOSE' was previously declared within a block
 concat.c:206: parse error before "char"
 concat.c:207: parse error before "const"
 make[1]: *** [concat.o] Error 1
 make[1]: Leaving directory `/scratch/mmokrejs/gdb-5.2.1/libiberty'
 make: *** [all-libiberty] Error 2
 
 Have you seen this error?
 
 >
 > The following patch is required to get gdb compiling when readline 4.3
 > is installed.  Without this patch I get the following error message on
 > Solaris 8 using the SUN Forte compiler:
 >
 > cc-wrapper -c -g  -I/usr/include/v9  -I. -I. -I./config -DHAVE_CONFIG_H -I./../include/opcode -I./../readline/.. -I../bfd -I./../bfd  -I./../include -I../intl -I./../intl  -DMI_OUT=1 -DUI_OUT=1   event-top.c
 > "/local/include/readline/tilde.h", line 68: identifier redeclared: tilde_expand
 >         current : function(pointer to const char) returning pointer to char
 >         previous: function(pointer to char) returning pointer to char : "./defs.h", line 815
 > cc: acomp failed for event-top.c
 > make[1]: *** [event-top.o] Error 2
 > make[1]: Leaving directory `/usit/gryffindor/local/store/gryffindor/gdb-c/src-5.2.1-sun4os58/gdb'
 >
 > diff -ru src-5.2.1/gdb/defs.h src-5.2.1-local/gdb/defs.h
 > --- src-5.2.1/gdb/defs.h        2002-11-01 13:09:44.000000000 +0100
 > +++ src-5.2.1-local/gdb/defs.h  2002-12-03 11:57:08.000000000 +0100
 > @@ -812,7 +812,7 @@
 >
 >  /* From readline (but not in any readline .h files).  */
 >
 > -extern char *tilde_expand (char *);
 > +extern char *tilde_expand (const char *);
 >
 >  /* Control types for commands */
 >
 
 -- 
 Martin Mokrejs <mmokrejs@natur.cuni.cz>, <m.mokrejs@gsf.de>
 PGP5.0i key is at http://www.natur.cuni.cz/~mmokrejs
 MIPS / Institute for Bioinformatics <http://mips.gsf.de>
 GSF - National Research Center for Environment and Health
 Ingolstaedter Landstrasse 1, D-85764 Neuherberg, Germany
 tel.: +49-89-3187 3683 , fax: +49-89-3187 3585