gdb/37: testsuite/gdb.base/list.exp has unmatching PASS/FAIL

[chastain at redhat dot com]

>Number:         37
>Category:       gdb
>Synopsis:       testsuite/gdb.base/list.exp has unmatching PASS/FAIL
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Mar 09 21:18:00 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     chastain@redhat.com
>Release:        cvs 2001-03-08
>Organization:
>Environment:
source review
>Description:
File testsuite/gdb.base/list.exp
  proc test_list_filename_and_number
  proc test_list_forward
  proc test_repeat_list_command
  proc test_list_backwards
  proc test_list_filename_and_function

These test procs have many FAIL calls with no matching PASS.
The individual tests can FAIL, but instead of PASSing,
a variable "testcnt" is incremented.  At the end of each
test proc, a single PASS reports:

  pass "list filename:number ($testcnt tests)"

This makes it harder to compare results across test runs.
I've got a set of result files with FAILs in some of them,
and no matching PASSes for the configurations that pass!
>How-To-Repeat:
Find a test that FAILs on some platforms and does not FAIL
on others.  Note that there is no PASS when the test
succeeds.
>Fix:
Kill the "incr testcnt" logic.  Simply call PASS when the
test passes.  Then kill the aggregate PASS at the bottom.
>Release-Note:
>Audit-Trail:
>Unformatted: