This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 1/2] Remove cleanups from gdb_readline_wrapper

From: Tom Tromey <tom at tromey dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Sun, 25 Mar 2018 10:19:42 -0600
Subject: Re: [RFA 1/2] Remove cleanups from gdb_readline_wrapper
References: <20180323033843.29577-1-tom@tromey.com> <20180323033843.29577-2-tom@tromey.com> <afb5d004-17dc-e0d6-d96c-607c165116bc@redhat.com>

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> I think we can move these to the ctor too, and then all the fields
Pedro> of the structure can be made private.  Something like the patch
Pedro> below.  (Tested on x86-64 GNU/Linux.)

Seems like a good idea to me.

Pedro> While at it, since we're touching most of the structure, we might as
Pedro> well reindent it to have open { at column 0.  (Not done below to keep
Pedro> the patch readable.)

I added this and did the reindentation.
Also I removed the "explicit" from the constructor.

Tom

References:
- [RFA 0/2] two simple cleanup removals
  - From: Tom Tromey
- [RFA 1/2] Remove cleanups from gdb_readline_wrapper
  - From: Tom Tromey
- Re: [RFA 1/2] Remove cleanups from gdb_readline_wrapper
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]