This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Remove struct keyword from section_addr_info
- From: Simon Marchi <simark at simark dot ca>
- To: Keith Seitz <keiths at redhat dot com>, gdb-patches at sourceware dot org
- Date: Fri, 23 Mar 2018 22:45:28 -0400
- Subject: Re: [PATCH] Remove struct keyword from section_addr_info
- References: <20180323203608.8939-1-keiths@redhat.com>
On 2018-03-23 04:36 PM, Keith Seitz wrote:
> Buildbot pointed out a failiure in windows-nat.c:
>
> ../../binutils-gdb/gdb/windows-nat.c:582:10: error: using typedef-name 'section_addr_info' after 'struct'
> struct section_addr_info *addrs;
> ^~~~~~~~~~~~~~~~~
> In file included from ../../binutils-gdb/gdb/windows-nat.c:49:0:
> ../../binutils-gdb/gdb/symfile.h:75:37: note: 'section_addr_info' has a previous declaration here
> typedef std::vector<other_sections> section_addr_info;
> ^~~~~~~~~~~~~~~~~
>
> A recursive grep of the sources for "struct section_addr_info" reveals one
> additional reference in a comment. In both cases, this patch simply removes
> the struct keyword.
>
> gdb/ChangeLog:
>
> * symfile.c (place_section): Remove "struct" from section_addr_info
> in comment.
> * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Likewise.
The "Likewise" is not really accurate, since the second entry isn't changing
a comment like the first one. But otherwise LGTM (I would have considered it
as pretty obvious).
Simon