Re: [PATCH 1/2] gdb: Minor cleanup in some gdb.arch/* tests

[Pedro Alves <palves at redhat dot com>]

On 03/22/2018 12:57 PM, Andrew Burgess wrote:
> A small number of tests incorrectly tried to pass -Wa,-g through to
> GCC as an extra compile time flag, either to gdb_compile or
> prepare_for_testing.
> 
> There were two mistakes, first, the 'debug' flag was already being
> passed, this will cause GCC to add a suitable -g flag, which should
> then be propagated to the assembler.  Secondly, in order to pass
> additional compiler flags, the syntax would be
> 'additional_flags=-Wa,-g'.  As it was, the flag was just being
> ignored.
> 
> Given that all these tests pass 'debug', and the invalid flag has been
> ignored for some time, I'm just removing the flags in this commit.
> 
> There should be no change in the test results after this commit.

OK.

> -
>  if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \
> -	  [list debug $additional_flags]] } {
> +	  [list debug]] } {
>      return -1

Note you could make these {debug} instead now.  "[list ...]" was only
necessary because of variable expansion.  (Don't know whether that
shortens the lines enough to avoid wrapping).  Actually, "debug" is
the default, so you could just remove them completely:

  proc prepare_for_testing { testname executable {sources ""} {options {debug}}} {

Thanks,
Pedro Alves