[PATCH v4 00/10] Remove gdbserver dependency on xml files

[alan dot hayward at arm dot com]

From: Alan Hayward <alan.hayward@arm.com>

V4 addresses Philipps review comments. I'm fairly confident the issues he
found on s390 I reproduced on arm32, and have now fixed up - the code now
ensures xml is not generated for targets using older style descriptions.

Using git sendmail for the first time, which should sort out the formatting
issues I've had previously. However, just to the safe I've also pushed to
my patches to the remote branch users/ahayward/xml4.

This set adds two new patches to handle when to generate xml (fixing s390
issues) and the reg_defs vector change.

Summary:

For those targets that use new style target descriptions, this set of patches
removes the dependency on xml files. Namely:
* Removes inclusion of xml files within gdbserver.
* Removes the requirement for the .c files in features/ to be generated from
cached xml files.
This is made possible by changing xml descriptions generated by gdbserver, so
that instead of including xml file names, gdbserver now generate a complete
xml description.

The second point will be required for aarch64 SVE support, where the register
size are variable. Creating SVE xml files for every possible vector length
would not be feasible. Instead the plan for aarch64 SVE is to hand write the
features/ .c code that would normally be generated from xml.

Targets which use the older style target descriptions have not been changed.


XML Generation:

In existing code, gdbserver uses C code auto generated from xml files to
create target descriptions. When sending an xml description to GDB, the
function tdesc_get_features_xml () creates an xml containing the name of the
original xml file(s). For example:

<!DOCTYPE target SYSTEM "gdb-target.dtd">
<target>
  <architecture>i386</architecture>
  <osabi>GNU/Linux</osabi>
  <xi:include href="32bit-core.xml"/>
  <xi:include href="32bit-sse.xml"/>
  <xi:include href="32bit-linux.xml"/>
  <xi:include href="32bit-avx.xml"/>
</target>

Upon receipt, GDB then makes requests to gdbserver for the contents of the
xml files. Gdbserver keeps full copies all the xml files inside the binary.

This patch series adds common code that allows gdbserver (and gdb) to turn
a C target description structure into xml.
Now when asked fort an xml description to gdb, gdbserver turns the entire
target description structure back into xml, without using any cached files.
Producing, for example:

<!DOCTYPE target SYSTEM "gdb-target.dtd">
<target>
  <architecture>i386</architecture>
  <osabi>GNU/Linux</osabi>
  <feature name="org.gnu.gdb.i386.core">
    <flags id="i386_eflags" size="4">
      <field name="CF" start="0" end="0"/>
      <field name="" start="1" end="1"/>
      <field name="PF" start="2" end="2"/>
      <field name="AF" start="4" end="4"/>
...etc...


Patch Contents:

Patches 3-5 commonise the various target descriptor functionality, allowing
gdbserver to parse target descriptions in the same way as gdb. This series
does not commonise target_desc, but this is hopefully a long term goal.

The eighth patch adds the xml printer, which iterates through the parsing
generated in the previous patches.

The other patches are clean up patches.



Patches have been tested on a make check on x86 targets=all build with
target boards unix and native-gdbserver. Also built and tested aarch64 and
Arm32 (which uses old style descriptions)
In addition, patch six adds new test cases to unit test.

Alan.


Alan Hayward (10):
  Move tdesc header funcs to c file
  Make gdbserver reg_defs a vector of objects
  Commonise tdesc_reg
  Commonise tdesc_feature
  Commonise tdesc types
  Add tdesc osabi and architecture functions
  Add feature reference in .dat files
  Create xml from target descriptions
  Remove xml file references from target descriptions.
  Remove xml files from gdbserver

 gdb/Makefile.in                                    |   2 +
 gdb/common/tdesc.c                                 | 397 ++++++++++++++
 gdb/common/tdesc.h                                 | 312 ++++++++++-
 gdb/features/Makefile                              |   6 +
 gdb/features/aarch64-core.c                        |   2 +-
 gdb/features/aarch64-fpu.c                         |   2 +-
 gdb/features/i386/32bit-avx.c                      |   2 +-
 gdb/features/i386/32bit-avx512.c                   |   2 +-
 gdb/features/i386/32bit-core.c                     |   2 +-
 gdb/features/i386/32bit-linux.c                    |   2 +-
 gdb/features/i386/32bit-mpx.c                      |   2 +-
 gdb/features/i386/32bit-pkeys.c                    |   2 +-
 gdb/features/i386/32bit-sse.c                      |   2 +-
 gdb/features/i386/64bit-avx.c                      |   2 +-
 gdb/features/i386/64bit-avx512.c                   |   2 +-
 gdb/features/i386/64bit-core.c                     |   2 +-
 gdb/features/i386/64bit-linux.c                    |   2 +-
 gdb/features/i386/64bit-mpx.c                      |   2 +-
 gdb/features/i386/64bit-pkeys.c                    |   2 +-
 gdb/features/i386/64bit-segments.c                 |   2 +-
 gdb/features/i386/64bit-sse.c                      |   2 +-
 gdb/features/i386/x32-core.c                       |   2 +-
 gdb/features/tic6x-c6xp.c                          |   2 +-
 gdb/features/tic6x-core.c                          |   2 +-
 gdb/features/tic6x-gp.c                            |   2 +-
 gdb/gdbserver/Makefile.in                          |   3 +
 gdb/gdbserver/configure.srv                        |  28 -
 gdb/gdbserver/regcache.c                           |  27 +-
 gdb/gdbserver/regcache.h                           |   4 -
 gdb/gdbserver/tdesc.c                              | 244 ++++-----
 gdb/gdbserver/tdesc.h                              |  59 +-
 gdb/regformats/aarch64.dat                         |   1 +
 gdb/regformats/i386/amd64-avx-avx512-linux.dat     |   1 +
 gdb/regformats/i386/amd64-avx-linux.dat            |   1 +
 .../i386/amd64-avx-mpx-avx512-pku-linux.dat        |   1 +
 gdb/regformats/i386/amd64-avx-mpx-linux.dat        |   1 +
 gdb/regformats/i386/amd64-linux.dat                |   1 +
 gdb/regformats/i386/amd64-mpx-linux.dat            |   1 +
 gdb/regformats/i386/amd64.dat                      |   1 +
 gdb/regformats/i386/i386-avx-avx512-linux.dat      |   1 +
 gdb/regformats/i386/i386-avx-linux.dat             |   1 +
 .../i386/i386-avx-mpx-avx512-pku-linux.dat         |   1 +
 gdb/regformats/i386/i386-avx-mpx-linux.dat         |   1 +
 gdb/regformats/i386/i386-linux.dat                 |   1 +
 gdb/regformats/i386/i386-mmx-linux.dat             |   1 +
 gdb/regformats/i386/i386-mpx-linux.dat             |   1 +
 gdb/regformats/i386/i386.dat                       |   1 +
 gdb/regformats/i386/x32-avx-avx512-linux.dat       |   1 +
 gdb/regformats/i386/x32-avx-linux.dat              |   1 +
 gdb/regformats/i386/x32-linux.dat                  |   1 +
 gdb/regformats/regdat.sh                           |  12 +-
 gdb/regformats/tic6x-c62x-linux.dat                |   1 +
 gdb/regformats/tic6x-c64x-linux.dat                |   1 +
 gdb/regformats/tic6x-c64xp-linux.dat               |   1 +
 gdb/target-descriptions.c                          | 596 +++------------------
 gdb/xml-tdesc.c                                    |   9 +
 gdb/xml-tdesc.h                                    |   5 +
 57 files changed, 976 insertions(+), 792 deletions(-)
 create mode 100644 gdb/common/tdesc.c

-- 
2.14.3 (Apple Git-98)