This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] Remove two cleanups using std::string

From: Simon Marchi <simark at simark dot ca>
To: Tom Tromey <tom at tromey dot com>
Cc: gdb-patches at sourceware dot org
Date: Tue, 13 Mar 2018 21:32:11 -0400
Subject: Re: [RFA] Remove two cleanups using std::string
Authentication-results: sourceware.org; auth=none
References: <20180312223829.7108-1-tom@tromey.com> <d6ec890c-914b-b26b-e4c1-0d8c0408a8e7@simark.ca> <874lljtuhu.fsf@tromey.com>

On 2018-03-13 07:40 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
> 
> Simon> LGTM.  I would be more confident if that non-trivial escaping code was
> Simon> unit-tested, but I tried it by hand and it seems to do what it's supposed
> Simon> to do.
> 
> Yeah.  I looked at this briefly but it seemed like a lot of work for not
> a huge benefit.  Maybe if some other code was doing the same thing, it
> would make sense to pull this logic out into its own function.

Agreed.

References:
- [RFA] Remove two cleanups using std::string
  - From: Tom Tromey
- Re: [RFA] Remove two cleanups using std::string
  - From: Simon Marchi
- Re: [RFA] Remove two cleanups using std::string
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]