This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH 1/3] btrace: Remove btrace disable cleanup
- From: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 5 Mar 2018 12:39:13 +0000
- Subject: RE: [PATCH 1/3] btrace: Remove btrace disable cleanup
- Authentication-results: sourceware.org; auth=none
- Dlp-product: dlpe-windows
- Dlp-reaction: no-action
- Dlp-version: 11.0.0.116
- References: <20180304205605.13037-1-simon.marchi@polymtl.ca>
Hello Simon,
> This patch removes a cleanup that disables btrace on threads in case of
> failure, so we don't leave it enabled for some the threads and disabled
> for the rest.
>
> gdb/ChangeLog:
>
> * record-btrace.c (record_btrace_disable_callback): Remove.
> (struct scoped_btrace_disable): New.
> (record_btrace_open): Use scoped_btrace_disable.
Looks good to me.
Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928