This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/Darwin] Recognize .plt section
On 03/05/2018 11:59 AM, Joel Brobecker wrote:
>>> +2018-03-02 Tristan Gingold <gingold@adacore.com>
>>> +
>>> + Pushed by Xavier Roirand <roirand@adacore.com>
>>
>> Nowadays, in case of author != commiter, we don't write down the name of
>> committer in ChangeLog. Any reason you do so? I noticed that you did
>> this in several Tristan's patches.
>
> It's something I have been doing on occasions. The idea was that
> people working from source packages alone could see who did the push.
> But I'm not really attached to it, so this can be skipped if people
> prefer.
The GNU coding standards has section saying not to do that. From
<https://www.gnu.org/prep/standards/standards.html>:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
When you install someone else’s changes, put the contributor’s name in the change
log entry rather than in the text of the entry. In other words, write this:
2002-07-14 John Doe <jdoe@gnu.org>
* sewing.c: Make it sew.
rather than this:
2002-07-14 Usual Maintainer <usual@gnu.org>
* sewing.c: Make it sew. Patch by jdoe@gnu.org.
As for the date, that should be the date you applied the change.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Thanks,
Pedro Alves