This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Conditionally include "<windows.h>" on common/pathstuff.c (and unbreak build on mingw*)
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: gdb-patches at sourceware dot org, simon dot marchi at ericsson dot com, palves at redhat dot com, brobecker at adacore dot com, christophe dot lyon at linaro dot org
- Date: Fri, 02 Mar 2018 15:32:33 +0200
- Subject: Re: [PATCH] Conditionally include "<windows.h>" on common/pathstuff.c (and unbreak build on mingw*)
- Authentication-results: sourceware.org; auth=none
- References: <CAKdteOYtFqn-4Bvd2Tekjpf+h5D-8dTSLKSPXcC7YAMRrJ1TCw@mail.gmail.com> <20180301202005.11563-1-sergiodj@redhat.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Sergio Durigan Junior <sergiodj@redhat.com>
> Cc: Simon Marchi <simon.marchi@ericsson.com>, Pedro Alves <palves@redhat.com>, Joel Brobecker <brobecker@adacore.com>, Christophe Lyon <christophe.lyon@linaro.org>, Sergio Durigan Junior <sergiodj@redhat.com>
> Date: Thu, 1 Mar 2018 15:20:05 -0500
>
> +#ifdef USE_WIN32API
> +#include <windows.h>
> +#endif
Isn't USE_WIN32API specific to gdbserver? If so, perhaps it's better
to use __MINGW32__ or _WIN32 instead?