This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH 2/2] btrace: set/show record btrace cpu
- From: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 1 Mar 2018 16:23:59 +0000
- Subject: RE: [PATCH 2/2] btrace: set/show record btrace cpu
- Authentication-results: sourceware.org; auth=none
- Dlp-product: dlpe-windows
- Dlp-reaction: no-action
- Dlp-version: 11.0.0.116
- References: <1519379570-16643-1-git-send-email-markus.t.metzger@intel.com> <1519379570-16643-2-git-send-email-markus.t.metzger@intel.com> <83woz34xuj.fsf@gnu.org> <A78C989F6D9628469189715575E55B236964BF9A@IRSMSX104.ger.corp.intel.com> <83lgff1s4n.fsf@gnu.org> <A78C989F6D9628469189715575E55B236964C68C@IRSMSX104.ger.corp.intel.com> <83y3jez3yw.fsf@gnu.org> <A78C989F6D9628469189715575E55B236964DCE6@IRSMSX104.ger.corp.intel.com> <83po4pyvji.fsf@gnu.org> <A78C989F6D9628469189715575E55B236964E5AA@IRSMSX104.ger.corp.intel.com> <83muzryhql.fsf@gnu.org>
Hello Eli,
> > > > > @cindex processor errata
> > > > > @dfn{Processor errata} are bugs in processor firmware that can cause
> > > > > a trace not to match the specification. Trace decoders that are
> > > > > unaware of these errata might fail to decode such a trace.
> > > > > @value{GDBN} can detect erroneous trace packets and correct them,
> > > > > thus avoiding the decoding failures. These corrections are known as
> > > > > @dfn{errata workarounds}, and are enabled based on the processor on
> > > > > which the trace was recorded.
> > > >
> > > But that completely loses the explanation of what the errata are.
> > > If my explanation is not accurate, let's correct it, rather than deleting it.
> >
> > I didn't mean to delete your explanation. I only removed the 'firmware' part.
>
> The text I proposed is above. It begins with an explanation of what those errata
> are, and why they are detrimental to btrace. The text you proposed instead is
> this:
>
> Errata may cause the recorded trace to not match the specification.
> This, in turn, may cause trace decode to fail. @value{GDBN} can
> detect erroneous trace packets and correct them, thus avoiding the
> decoding failures. These corrections are known as @dfn{errata
> workarounds}, and are enabled based on the processor on which the
> trace was recorded.
>
> This just says that trace decode can fail, but tells nothing about the phenomenon
> itself. Thus my "completely loses" reaction.
>
> But I don't want to argue. If you feel that the text you wrote is good enough, go
> ahead and push it, even though I'm unhappy.
I'd rather we find a wording we can all agree on.
I added that errata cause the trace to not match the spec and that this would
cause decode to fail.
I removed the bit about errata being in the firmware since that is not correct.
And I replaced "unaware decoders might fail to decode such a trace" with "This,
in turn, may cause trace decode to fail".
The rest I took as you suggested.
Where do you think we need to improve the wording?
Thanks,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928