This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add test for load command

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simon dot marchi at polymtl dot ca>
Cc: gdb-patches at sourceware dot org, Tom Tromey <tom at tromey dot com>
Date: Mon, 26 Feb 2018 12:15:36 -0700
Subject: Re: [PATCH] Add test for load command
Authentication-results: sourceware.org; auth=none
References: <20180225173703.6675-1-tom@tromey.com> <20180225204354.6307-1-simon.marchi@polymtl.ca>

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> [[Hi Tom,
Simon>   What do you think of adding this test to check this code path?]]

Simon> There doesn't seem to by any test for the load command.  I suggest to
Simon> add this test, so that we can have a minimum of confidence we don't
Simon> break it completely while refactoring the code that implements it.

This seems like a good idea to me.  I read the test and it seems
reasonable.

Thank you very much for doing this.

Tom

Follow-Ups:
- Re: [PATCH] Add test for load command
  - From: Simon Marchi

References:
- [RFA] Change target_write_memory_blocks to use std::vector
  - From: Tom Tromey
- [PATCH] Add test for load command
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]