This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA v2 4/4] Handle DW_TAG_variant_part and DW_TAG_variant

From: Tom Tromey <tom at tromey dot com>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Mon, 26 Feb 2018 09:16:54 -0700
Subject: Re: [RFA v2 4/4] Handle DW_TAG_variant_part and DW_TAG_variant
Authentication-results: sourceware.org; auth=none
References: <20180222203018.23551-1-tom@tromey.com> <20180222203018.23551-5-tom@tromey.com> <20180226065620.z6dzyzrlr72kylnn@adacore.com>

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

>> 2018-02-22  Tom Tromey  <tom@tromey.com>
>> 
>> * dwarf2read.c (struct variant_field): New.
>> (struct nextfield) <variant>: New field.
>> (dwarf2_add_field): Handle DW_TAG_variant_part.
>> (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
>> discriminated union.

Joel> Looks good to me, Tom. Thanks!

Thanks for the reviews.  I've updated the patches.  Patch #4 needed a
minor adjustment to the new complaints to account for the recent 64-bit
sect_offset change.

Tom

References:
- [RFA v2 0/4] variants and variant parts
  - From: Tom Tromey
- [RFA v2 4/4] Handle DW_TAG_variant_part and DW_TAG_variant
  - From: Tom Tromey
- Re: [RFA v2 4/4] Handle DW_TAG_variant_part and DW_TAG_variant
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]