This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Fix frame argument printing when using auto language mode


Hi Yao,

> We don't have to do that.  ada_val_print_1 is called in ada_val_print,
> 
>       ada_val_print_1 (type, embedded_offset, address,
>        stream, recurse, val, options,
>        current_language);
> 
> and ada_val_print is language->la_val_print in effect, so "language"
> is ada_language_defn, and we can rewrite the code above like this,
> 
>       ada_val_print_1 (type, embedded_offset, address,
>        stream, recurse, val, options,
>        &ada_language_defn);
> 
> This change may break existing behaviour.  Printing for ada (or other
> languages) shouldn't depend on current_language, IMO.

Thanks for the extra pair of eyes, and the pertinent suggestions!
FWIW, I agree with you, your fix is much better.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]