This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] dwarf: Make sect_offset 64-bits
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, Simon Marchi <simon dot marchi at polymtl dot ca>, gdb-patches at sourceware dot org
- Date: Tue, 20 Feb 2018 16:49:31 +0000
- Subject: Re: [PATCH] dwarf: Make sect_offset 64-bits
- Authentication-results: sourceware.org; auth=none
- References: <1514692098-8054-1-git-send-email-simon.marchi@ericsson.com> <0694b84f-7fef-5373-2cb3-87f6b8fd56b7@polymtl.ca> <09806ce5-3e85-dacc-cf3e-22660fab90b8@ericsson.com>
On 02/20/2018 04:38 PM, Simon Marchi wrote:
> On 2018-01-28 12:26 PM, Simon Marchi wrote:
>> Does anybody have an opinion about this? It would be nice to unbreak
>> the "default" build with clang (i.e. without passing special -Wno-error=
>> flags).
>>
>> Here's a version rebased on today's master.
>
> Ping.
>
Does this change the type of any field of the structures that form the
indexes? I.e., does it affect binary compatibility there? I.e.,
can you save a gdb index with pre-patch gdb, and load it back in
post-patch gdb. Likewise viceversa. Also DWARF5 indexes.
Also, just for the record, can we assume that this doesn't increase
memory usage considerably when debugging bigger programs? I assume that
this will create some padding holes in some structures and that we can
probably win back the memory by just changing order of some fields
for better packing.
Offhand, I know about code in dwarf2read.c that assumes that offset_type
is 32-bit for both of the reasons above -- memory usage (e.g.,
struct name_component), and also as type used in indexes.
I'm not seeing anything for sect_offset, but can you double check?
Thanks,
Pedro Alves