This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Remove a few more cleanups: solib and openp
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Wed, 14 Feb 2018 13:55:35 +0000
- Subject: Re: Remove a few more cleanups: solib and openp
- Authentication-results: sourceware.org; auth=none
- References: <20180213233907.11259-1-tom@tromey.com>
On 02/13/2018 11:39 PM, Tom Tromey wrote:
> This series removes a few cleanups by using unique_xmalloc_ptr. This
> also helps clarify the ownership rules of a few APIs. This series
> also includes a couple of minor (non-cleanup-related) code clarity
> improvements in related areas: moving some declarations out of defs.h,
> and a constification.
>
> Regression tested by the buildbot.
Nice! LGTM. Please push.
I was wondering whether you'd write patch #1 the other day you
touched some of that code. :-) On that patch, you may want to remove
the "The returned pathname is malloc'ed and must be freed by the caller."
remarks from the intro comments of (at least) solib_find_1,
exec_file_find and solib_find (in solib.c).
Thanks,
Pedro Alves