This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Check for ncursesw first when searching for "tgetent"
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Simon Marchi <simark at simark dot ca>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Date: Tue, 13 Feb 2018 14:04:56 -0500
- Subject: Re: [PATCH] Check for ncursesw first when searching for "tgetent"
- Authentication-results: sourceware.org; auth=none
- References: <20180131210430.23787-1-sergiodj@redhat.com> <c60a4d66-6fa5-fd06-a86d-8184d84ac1a0@simark.ca>
On Monday, February 12 2018, Simon Marchi wrote:
> On 2018-01-31 04:04 PM, Sergio Durigan Junior wrote:
>> Commit 5007d765ae09c10c7f3b18bb16841b9d2d59e181 ("Allow linking GDB
>> with ncursesw") modified our configure.ac and included the check for
>> "ncursesw" when searching for "waddstr". However, there's one more
>> place where we should check for "ncursesw" first:
>>
>> AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncursesw ncurses])
>>
>> This patch changes the order of the libraries to be searched when
>> looking for "tgetent", and puts "ncursesw" before "curses ...".
>>
>> This is another patch we carry on Fedora GDB.
>
> I think it makes sense, but can you expand on why this is needed?
The rationale for this patch was:
https://bugzilla.redhat.com/show_bug.cgi?id=1270534
This is a bug that happened on Fedora GDB when linking against ncurses,
but not ncursesw. The bug has been fixed upstream by commit
5007d765ae09c10c7f3b18bb16841b9d2d59e181, but the AC_SEARCH_LIBS line
for tgetent has not been modified, so, for the sake of completeness, I
think it makes sense to leave configure.ac in a consistent state (i.e.,
requiring ncursesw over ncurses whenever applicable).
I guess that's the gist of it. There's not much that can be said, the
patch is really simple and its intention is to make things more uniform.
I can include the link to the Red Hat bug in the commit message, if you
want.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/