This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Do not classify C struct members as a filename
- From: "Leszek Swirski via gdb-patches" <gdb-patches at sourceware dot org>
- To: Tom Tromey <tom at tromey dot com>
- Cc: Leszek Swirski via gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 25 Jan 2018 16:38:55 +0000
- Subject: Re: [PATCH v2] Do not classify C struct members as a filename
- Authentication-results: sourceware.org; auth=none
- References: <20180124165107.186980-1-leszeks@google.com> <87zi52gc8u.fsf@tromey.com>
- Reply-to: Leszek Swirski <leszeks at google dot com>
> This change makes sense (and thanks for updating that comment as well),
> but I wonder whether this changes the behavior in some case. Elsewhere
> in lex_one_token there is a check of saw_structop:
>
> else if (saw_structop)
> return COMPLETE;
>
> Previously this return could only be taken if parse_completion was set,
> but now I think it could be taken in other situations.
>
> So, I suspect "parse_completion &&" should be stuck in there.
Nice catch, thanks! I looked at the other users of saw_structop and
last_was_structop, and it looks like this is the only location that
needs an update. PTAL at v4.