This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PING][PATCH] Fix for prologue processing on PowerPC
- From: Pedro Franco de Carvalho <pedromfc at linux dot vnet dot ibm dot com>
- To: Nikola Prica <nikola dot prica at rt-rk dot com>, Kevin Buettner <kevinb at redhat dot com>
- Cc: gdb-patches at sourceware dot org, "Ananthakrishna Sowda \(asowda\)" <asowda at cisco dot com>, "Ivan Baev \(ibaev\)" <ibaev at cisco dot com>, "'Nemanja Popov'" <nemanja dot popov at rt-rk dot com>, Djordje Todorovic <Djordje dot Todorovic at rt-rk dot com>, Ulrich dot Weigand at de dot ibm dot com
- Date: Fri, 19 Jan 2018 17:01:15 -0200
- Subject: Re: [PING][PATCH] Fix for prologue processing on PowerPC
- Authentication-results: sourceware.org; auth=none
- Https: //sourceware.org/ml/gdb-patches/2017-11/msg00207.html Hello Nikola, Is that the version you meant to send? That looks like the same as this one: Thanks, Pedro
- References: <f90d189e-7ec5-34f9-c776-8af42a3c07a6@rt-rk.com> <e3274bee-eb2d-3706-3af0-59f28c9c0899@rt-rk.com> <20171108095850.394a48ca@pinnacle.lan> <8bf0014c-e83c-5988-4d06-173572f21186@rt-rk.com> <7ba16b14-9384-34d9-937e-531a2192842a@linux.vnet.ibm.com> <e2997ed1-593e-16a8-7834-139ad8a56c6a@rt-rk.com> <87608p4dgr.fsf@linux.vnet.ibm.com> <f127aabe-a185-4ab2-0e3e-cc7776317646@rt-rk.com> <87r2qx4oit.fsf@linux.vnet.ibm.com> <20038806-69e5-b7ce-479b-54185089145b@rt-rk.com> <90e3f502-7d22-d22e-4bf0-3b0db43347d6@rt-rk.com>
Nikola Prica <nikola.prica@rt-rk.com> writes:
> Hi Pedro,
>
> I've just seen that changed version of patch was not attached.
>
> Best regards,
>
> Nikola Prica
> From 3564cd3be620bb39ca615919148fa0d949284d35 Mon Sep 17 00:00:00 2001
> From: Prica <nprica@rt-rk.com>
> Date: Thu, 9 Nov 2017 13:10:48 +0100
> Subject: [PATCH] Fix for prologue processing on PowerPC
>
> One of conditions in skip_prologue() is never visited because it
> expects non shifted `lr_reg`. That condition is supposed to set PC
> offset. When body of this condition is visited PC offset is set and
> there will be no need to look for it in next frames nor to use frame
> unwind directives.
>
> gdb/ChangeLog:
> *rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg
> and assign shifted lr_reg to fdata->lr_register when lr_reg is
> set. If iteration do not hit lim_pc lr_register is set as -1.
> ---
> gdb/rs6000-tdep.c | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
> index 6c44995..6f05ef5 100644
> --- a/gdb/rs6000-tdep.c
> +++ b/gdb/rs6000-tdep.c
> @@ -1655,9 +1655,12 @@ skip_prologue (struct gdbarch *gdbarch, CORE_ADDR pc, CORE_ADDR lim_pc,
> remember just the first one, but skip over additional
> ones. */
> if (lr_reg == -1)
> - lr_reg = (op & 0x03e00000) >> 21;
> - if (lr_reg == 0)
> - r0_contains_arg = 0;
> + {
> + lr_reg = (op & 0x03e00000);
> + fdata->lr_register = lr_reg >> 21;
> + if (lr_reg == 0)
> + r0_contains_arg = 0;
> + }
> continue;
> }
> else if ((op & 0xfc1fffff) == 0x7c000026)
> @@ -2180,8 +2183,8 @@ skip_prologue (struct gdbarch *gdbarch, CORE_ADDR pc, CORE_ADDR lim_pc,
> }
> #endif /* 0 */
>
> - if (pc == lim_pc && lr_reg >= 0)
> - fdata->lr_register = lr_reg;
> + if (pc != lim_pc)
> + fdata->lr_register = -1;
>
> fdata->offset = -fdata->offset;
> return last_prologue_pc;
> --
> 2.7.4