This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] gdb: Add missing #ifdef USE_THREAD_DB to gdbserver
- From: Pedro Alves <palves at redhat dot com>
- To: James Clarke <jrtc27 at jrtc27 dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 19 Jan 2018 16:57:18 +0000
- Subject: Re: [PATCH 2/2] gdb: Add missing #ifdef USE_THREAD_DB to gdbserver
- Authentication-results: sourceware.org; auth=none
- References: <20171215000434.47315-1-jrtc27@jrtc27.com> <20171215000434.47315-2-jrtc27@jrtc27.com> <dcbb4ef4-6019-d271-a705-fa7bd002d330@redhat.com> <1BA91B1E-5E4A-4084-822C-3A35ADB4390C@jrtc27.com>
On 01/19/2018 04:55 PM, James Clarke wrote:
> On 19 Jan 2018, at 16:48, Pedro Alves <palves@redhat.com> wrote:
>> On 12/15/2017 12:04 AM, James Clarke wrote:
>>> gdb/ChangeLog:
>>> * gdbserver/linux-low.c (handle_extended_wait): Surround call to
>>> thread_db_notice_clone with #ifdef USE_THREAD_DB.
>>> ---
>>> [Originally erroneously sent to the binutils mailing list]
>>
>> Looks OK, but could you remind me what goes wrong if we
>> don't do this? Does gdbserver fail to link?
>
> Yes, with the expected:
>
>> [...]/linux-low.c:664: undefined reference to `thread_db_notice_clone(thread_info*, ptid_t)'
>
> Every other use of thread_db_* is guarded by USE_THREAD_DB, so I assume it's
> fine to do here too.
Thanks for the clarification. Please add that to the commit log,
and push it in.
Thanks,
Pedro Alves