This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC][PATCH] fix gdb segv when objfile can't be opened

From: Mike Gulick <mgulick at mathworks dot com>
To: Simon Marchi <simon dot marchi at polymtl dot ca>
Cc: Simon Marchi <simon dot marchi at ericsson dot com>, Mike Gulick <mike dot gulick at mathworks dot com>, gdb-patches at sourceware dot org
Date: Fri, 12 Jan 2018 10:04:52 -0500
Subject: Re: [RFC][PATCH] fix gdb segv when objfile can't be opened
Authentication-results: sourceware.org; auth=none
References: <59E8B251.4050100@mathworks.com> <8c08307a-94ad-92b8-9c8b-c713cad541fd@mathworks.com> <56b1cb34b33613ca4496abfcd28f135a@polymtl.ca> <c17d5f02-1afd-dcdd-2855-531d9725e3c1@mathworks.com> <46f29b7d-852e-8db1-d7e7-d59c5857d3c0@ericsson.com> <82a1c23a-37f4-dee5-beae-da95d1cc1c6c@mathworks.com> <9ee6ad949b591f29f5205d00ce8527ff@polymtl.ca> <2faa1373-dd43-8816-99e9-bb03178b014b@ericsson.com> <5503714c-9f45-c1c5-3258-75abeb40e832@mathworks.com> <aca01354700f3d63d52720eefc984364@polymtl.ca> <991575a07a4614be2c9aa5aa6dcf2ea7@polymtl.ca> <eda96337-b5a7-8d76-b0c8-c1b638c47004@mathworks.com> <0b995e7e758a2d7fb43689c282264870@polymtl.ca>
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99


On 01/11/2018 09:44 PM, Simon Marchi wrote:
> On 2018-01-10 15:33, Mike Gulick wrote:
>> Hi Simon,
>>
>> I received the signed assignment agreement back from the FSF yesterday.  I
>> rebased my patches on the current gdb tip and re-ran the test suite, with no
>> unexpected regressions.  Should I re-post the patches?
>>
>> Thanks,
>> Mike
> 
> Hi Mike,
> 
> I don't think reposting the patch is necessary, unless it changed substantially when rebasing.
> 
> I suppose you don't have push access to Sourceware yet?  If you plan on contributing to GDB regularly, it would be a good idea to get it, see [1] for details.  Otherwise I can push the patch for you, it's as you wish.
> 
> FYI, I just pushed the patch that fixes the shlib= problem you had:
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=6181e9c2c5ba252ac016f51903dc35d7bfbbca71
> 
> Simon
> 
> [1] https://sourceware.org/cgi-bin/pdw/ps_form.cgi

Hi Simon,

There weren't any code changes when rebasing.  The only changes I have locally
are just updating the changelog dates, and adding the missing tabs in the
changelog section of the commit message.  Feel free to push the change already
posted, with any fixups you see as necessary.

Next time I have a change to be submitted, I'll look into getting a Sourceware
account.

Thanks,
Mike

Follow-Ups:
- Re: [RFC][PATCH] fix gdb segv when objfile can't be opened
  - From: Simon Marchi

References:
- Re: [RFC][PATCH] fix gdb segv when objfile can't be opened
  - From: Simon Marchi
- Re: [RFC][PATCH] fix gdb segv when objfile can't be opened
  - From: Mike Gulick
- Re: [RFC][PATCH] fix gdb segv when objfile can't be opened
  - From: Simon Marchi
- Re: [RFC][PATCH] fix gdb segv when objfile can't be opened
  - From: Simon Marchi
- Re: [RFC][PATCH] fix gdb segv when objfile can't be opened
  - From: Mike Gulick
- Re: [RFC][PATCH] fix gdb segv when objfile can't be opened
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]