This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PING][PATCH] Fix for prologue processing on PowerPC
- From: Nikola Prica <nikola dot prica at rt-rk dot com>
- To: Pedro Franco de Carvalho <pedromfc at linux dot vnet dot ibm dot com>, Kevin Buettner <kevinb at redhat dot com>
- Cc: gdb-patches at sourceware dot org, "Ananthakrishna Sowda (asowda)" <asowda at cisco dot com>, "Ivan Baev (ibaev)" <ibaev at cisco dot com>, 'Nemanja Popov' <nemanja dot popov at rt-rk dot com>, Djordje Todorovic <Djordje dot Todorovic at rt-rk dot com>, Ulrich dot Weigand at de dot ibm dot com
- Date: Thu, 11 Jan 2018 16:12:15 +0100
- Subject: Re: [PING][PATCH] Fix for prologue processing on PowerPC
- Authentication-results: sourceware.org; auth=none
- References: <f90d189e-7ec5-34f9-c776-8af42a3c07a6@rt-rk.com> <e3274bee-eb2d-3706-3af0-59f28c9c0899@rt-rk.com> <20171108095850.394a48ca@pinnacle.lan> <8bf0014c-e83c-5988-4d06-173572f21186@rt-rk.com> <7ba16b14-9384-34d9-937e-531a2192842a@linux.vnet.ibm.com> <e2997ed1-593e-16a8-7834-139ad8a56c6a@rt-rk.com> <87608p4dgr.fsf@linux.vnet.ibm.com> <f127aabe-a185-4ab2-0e3e-cc7776317646@rt-rk.com> <87r2qx4oit.fsf@linux.vnet.ibm.com>
Hi Pedro,
I understand it now. Thank you for explanation.
> I'm just not sure that the bitwise operations with
> lr_reg are safe considering it is an int (e.g., is lr_reg | 0x90010000
> well-defined?).
>
Regarding that lr_reg is changed to valid value only when it is
previously set -1 and that it is changed like lr_reg = (op & 0x03e00000)
it means that it only takes bits between 21-26. I would say that it is
safe. I suppose that it is set to int for easier way of verifying its
validity.
Thanks,
Nikola Prica