This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Fix gdb.ada/bp_c_mixed_case.exp (PR gdb/22670) (Re: [PATCH 3/3] Add new gdb.ada/bp_c_mixed_case testcase for PR gdb/22670)
Hi Pedro,
> The main idea behind making the name matcher be determined by
> the symbol's language is so that C++ (etc.) wildmatching in
> linespecs works even if the current language is not C++, as e.g.,
> when you step through C or assembly code.
>
> Ada's verbatim matching syntax however ("<...>") isn't quite
> the same. It is more a property of the current language than
> of a particular symbol's language. We want to support
> this syntax when debugging an Ada program, but it's reason of
> existence is to find non-Ada symbols. This suggests going back
> to enabling it depending on current language instead of language
> of the symbol being matched.
That's a good way of describing the situation.
> I'm not entirely happy with the "current_language" reference
> (though I think that it's harmless). I think we could try storing the
> current language in the lookup_name_info object, and then convert
> a bunch of functions more to pass around lookup_name_info objects
> instead of "const char *" names. I.e., build the lookup_name_info
> higher up. I'm not sure about that, I'll have to think more
> about it. Maybe something different will be better.
I understand. I have the same feeling in general.
> It doesn't help that I'm not used to debugging Ada code, but the
> recent testcase additions surely have helped understand better the
> intended use cases. Thanks much for those.
My pleasure. I also have the same feeling, but with debugging
C++ right now, so I can certainly relate!
> Meanwhile, this looks small- and safe-enough for 8.1, to me.
> WDYT?
>
> I'd extended the testcase to also exercise a no-debug-info
> function, for extra coverage of the minsyms-only paths.
Thanks! The patch looks good to me. A few minor typos below...
> >From d1f377264f278d2839c3cf331e931c7382114e11 Mon Sep 17 00:00:00 2001
> From: Pedro Alves <palves@redhat.com>
> Date: Tue, 9 Jan 2018 14:48:55 +0000
> Subject: [PATCH] Ada: make verbatim matcher override other language matchers
> (PR gdb/22670)
>
> gdb/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> PR gdb/22670
> * dwarf2read.c
> (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
> Adjust to use language_get_symbol_name_matcher instead of
> language_defn::la_get_symbol_name_matcher.
> * language.c (language_get_symbol_name_matcher): In in Ada mode
^^^^^
|||||
> and the lookup name is a verbatim match, return Ada's matcher.
> * language.h (language_get_symbol_name_matcher): Adjust comment.
> (ada_lookup_name_info::verbatim_p):: New method.
>
> gdb/testsuite/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> PR gdb/22670
> * gdb.ada/bp_c_mixed_case.exp: Add intro comment. Test printing C
> functions too. Test setting breakpoints and printing C functions
> with no debug info too.
> * gdb.ada/bp_c_mixed_case/qux.c: New file.
> +# Try printing again using the "<...>" notation. This shouldn work
^^^^^^^
|||||||
I tested this patch on x86_64-linux, using both the official testsuite
as well as AdaCore's testsuite. No regression :).
Thanks, Pedro!
--
Joel