This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix gdb.ada/complete.exp's "complete break ada" test (PR, gdb/22670) (Re: [PATCH 2/3] Add "complete break ada" test to gdb.ada/complete.exp)

Hi Pedro,

> >From 2805fc780e497535f3966dea932023cad9b92b61 Mon Sep 17 00:00:00 2001
> From: Pedro Alves <palves@redhat.com>
> Date: Fri, 5 Jan 2018 12:21:25 +0000
> Subject: [PATCH 2/2] Fix gdb.ada/complete.exp's "complete break ada" test (PR
>  gdb/22670)
[...]
> gdb/ChangeLog:
> yyyy-mm-dd  Pedro Alves  <palves@redhat.com>
> 
>         PR gdb/22670
> 	* ada-lang.c (ada_collect_symbol_completion_matches): If the
> 	minsym's language is language_auto or language_cplus, pass down
> 	language_ada instead.
> 	* symtab.c (compare_symbol_name): Don't frob symbol language here.
> 
> gdb/testsuite/ChangeLog:
> yyyy-mm-dd  Pedro Alves  <palves@redhat.com>
> 
>         PR gdb/22670
> 	* gdb.ada/complete.exp ("complete break ada"): Replace kfail with
> 	a fail.

Thanks Pedro!

This patch looks good to me. In a way, I'm glad the Ada exception
is moving back to an ada-* file...

FTR, I tested this patch on x86_64-linux against AdaCore's testsuite
as well.

-- 
Joel
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]