This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] DWARF-5 .debug_names DW_IDX_type_unit fix [Re: [PATCH v3.2 5/5] DWARF-5: .debug_names index consumer]

From: Pedro Alves <palves at redhat dot com>
To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
Cc: gdb-patches at sourceware dot org, Victor Leschuk <vleschuk at accesssoftek dot com>
Date: Wed, 13 Dec 2017 23:03:12 +0000
Subject: Re: [patch] DWARF-5 .debug_names DW_IDX_type_unit fix [Re: [PATCH v3.2 5/5] DWARF-5: .debug_names index consumer]
Authentication-results: sourceware.org; auth=none
References: <149790572259.20186.14601775821404892582.stgit@host1.jankratochvil.net> <149790576669.20186.17091294504362630191.stgit@host1.jankratochvil.net> <20170628212114.GA23559@host1.jankratochvil.net> <20170702142957.GA22686@host1.jankratochvil.net> <628074a3-b992-1d96-273e-ecdf1e90bd8c@redhat.com> <20171212165221.GA12449@host1.jankratochvil.net> <20171213215731.GA32208@host1.jankratochvil.net> <10aa4fac-5924-0620-297c-436f4386fe0b@redhat.com>

On 12/13/2017 10:15 PM, Pedro Alves wrote:
> On 12/13/2017 09:57 PM, Jan Kratochvil wrote:

>>> The .debug_names completely misses its support as it does not even produce
>>> DW_IDX_type_unit.
>>
>> Here you are, could you also verify my regression testing for this patch?
> 
> Thanks!  I'm testing right away.

Yep, it fixes all regressions compared to .gdb_index.

Please fix the following nits and push:

> +  int dwarf5_offset_size () const {

The '{' goes on the next line.

> +  /* A helper function that writes a single signatured_type to an
> +     debug_names.  */

Typo: "to an" => "to a".

OK with those fixed.

Thanks,
Pedro Alves

Follow-Ups:
- [commit] DWARF-5 .debug_names DW_IDX_type_unit fix [Re: [PATCH v3.2 5/5] DWARF-5: .debug_names index consumer]
  - From: Jan Kratochvil

References:
- Re: [PATCH v3.2 5/5] DWARF-5: .debug_names index consumer
  - From: Pedro Alves
- Re: [PATCH v3.2 5/5] DWARF-5: .debug_names index consumer
  - From: Jan Kratochvil
- [patch] DWARF-5 .debug_names DW_IDX_type_unit fix [Re: [PATCH v3.2 5/5] DWARF-5: .debug_names index consumer]
  - From: Jan Kratochvil
- Re: [patch] DWARF-5 .debug_names DW_IDX_type_unit fix [Re: [PATCH v3.2 5/5] DWARF-5: .debug_names index consumer]
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]