This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[pushed, MPFR] Fix regression on 32-bit host systems
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: gdb-patches at sourceware dot org
- Date: Mon, 11 Dec 2017 15:29:08 +0100 (CET)
- Subject: [pushed, MPFR] Fix regression on 32-bit host systems
- Authentication-results: sourceware.org; auth=none
Hello,
when converting parts of the mantissa to MPFR, we need to make sure to do
an *unsigned* conversion. Since we convert at most 32 bits at a time,
stored in an unsigned long, this doesn't matter on systems where "long"
is larger than 32 bits. But on systems where it is 32 bits, we can get
conversion errors.
Tested on x86_64-linux and i686-linux, pushed to mainline.
Bye,
Ulrich
gdb/ChangeLog
2017-12-11 Ulrich Weigand <uweigand@de.ibm.com>
* target-float.c (mpfr_float_ops::from_target): Use mpfr_set_ui
instead of mpfr_set_si to convert mantissa bits.
diff --git a/gdb/target-float.c b/gdb/target-float.c
index b40b641..9b14609 100644
--- a/gdb/target-float.c
+++ b/gdb/target-float.c
@@ -1312,7 +1312,7 @@ mpfr_float_ops::from_target (const struct floatformat *fmt,
mant = get_field (from, order, fmt->totalsize, mant_off, mant_bits);
- mpfr_set_si (tmp.val, mant, MPFR_RNDN);
+ mpfr_set_ui (tmp.val, mant, MPFR_RNDN);
mpfr_mul_2si (tmp.val, tmp.val, exponent - mant_bits, MPFR_RNDN);
mpfr_add (to.val, to.val, tmp.val, MPFR_RNDN);
exponent -= mant_bits;
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com