This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/4] Implement 'set honor-dontdump-flag' command


On Wednesday, November 29 2017, Sergio Lopez wrote:

> On Wed, Nov 29, 2017 at 8:39 PM, Sergio Durigan Junior
> <sergiodj@redhat.com> wrote:
>> The previous line is the one breaking our coding style.  Unfortunately
>> GDB is full of these inconsistencies, but please remove the empty line
>> in your patch anyway.
>
> Ack, not a problem.
>
> Is there something else you'd like to see fixed in v3? In case you
> don't, do you prefer me to send the whole patchset as v3, or just
> patch 1/4?

The only thing I'd like is a testcase for this feature.  This is
required since it is a regression.  If you need any help to write one,
please let me know.

Once you have a testcase, you could just send patch 1/4 again.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]