This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, gdb/testsuite] Fix wrong return type in tests

From: Pedro Alves <palves at redhat dot com>
To: Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>, GDB Patches <gdb-patches at sourceware dot org>
Date: Wed, 29 Nov 2017 12:06:32 +0000
Subject: Re: [PATCH, gdb/testsuite] Fix wrong return type in tests
Authentication-results: sourceware.org; auth=none
References: <e998867a-08b5-cbf2-004b-b9ce3d73c588@foss.arm.com> <964a7f20-21f0-3e7f-a46a-6ef34cef046c@redhat.com> <0bde66e5-b4fe-7d63-66d7-4882855b03aa@foss.arm.com>

On 11/29/2017 11:59 AM, Thomas Preudhomme wrote:
> My apologize, I thought it couldn't be significant since it was not
> returning anything.  I didn't think about the impact on the prototype
> itself. 

No worries.  It was easy to miss.

How about making it return 0 instead then?

Yes please, go ahead and push such a fix in.

Thanks,
Pedro Alves

Follow-Ups:
- Re: [PATCH, gdb/testsuite] Fix wrong return type in tests
  - From: Thomas Preudhomme

References:
- [PATCH, gdb/testsuite] Fix wrong return type in tests
  - From: Thomas Preudhomme
- Re: [PATCH, gdb/testsuite] Fix wrong return type in tests
  - From: Pedro Alves
- Re: [PATCH, gdb/testsuite] Fix wrong return type in tests
  - From: Thomas Preudhomme

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]