This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA v2 1/2] Fix add-symbol-file usage and errors


On 11/25/2017 08:35 PM, Tom Tromey wrote:
> This patch updates add-symbol-file help and error text.
> 
> It changes add-symbol-file to throw an exception if "-s" is seen but
> not all of the arguments are given.  Previously this was silently
> ignored.
> 
> It changes the unrecognized argument message to more clearly state
> what went wrong.
> 
> Finally, it updates the usage line in the help text to follow GNU
> style regarding "metasyntactic variables"; a change I believe should
> be made to all gdb help messages.
> 

LGTM.  Thanks much for the update.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]