Re: [PATCH 2/4] Document new 'set honor-dontdump-flag' command

[Sergio Durigan Junior <sergiodj at redhat dot com>]

On Tuesday, November 28 2017, Sergio Lopez wrote:

> 2017-11-28  Sergio Lopez  <slp@redhat.com>
>
>         * gdb.texinfo (gcore): Mention new command 'set
>         honor-dontdump-flag'.
>         (set honor-dontdump-flag): Document new command.
> ---
>  gdb/doc/ChangeLog   |  6 ++++++
>  gdb/doc/gdb.texinfo | 14 +++++++++++++-
>  2 files changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
> index 2a1eb76d15..cdde49a887 100644
> --- a/gdb/doc/ChangeLog
> +++ b/gdb/doc/ChangeLog
> @@ -1,3 +1,9 @@
> +2017-11-28  Sergio Lopez  <slp@redhat.com>
> +
> +	* gdb.texinfo (gcore): Mention new command 'set
> +	honor-dontdump-flag'.
> +	(set honor-dontdump-flag): Document new command.
> +
>  2017-11-26  Dominik Czarnota  <dominik.b.czarnota@gmail.com>
>  
>  	PR gdb/21945
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 675f6e7bc8..472a0fe8cc 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -11543,7 +11543,9 @@ this writing, @sc{gnu}/Linux, FreeBSD, Solaris, and S390).
>  
>  On @sc{gnu}/Linux, this command can take into account the value of the
>  file @file{/proc/@var{pid}/coredump_filter} when generating the core
> -dump (@pxref{set use-coredump-filter}).
> +dump (@pxref{set use-coredump-filter}), and will honor the VM_DONTDUMP
> +flag for sections where is present in the file
> +@file{/proc/@var{pid}/smaps} (@pxref{set honor-dontdump-flag}).
>  
>  @kindex set use-coredump-filter
>  @anchor{set use-coredump-filter}
> @@ -11573,6 +11575,16 @@ value is currently @code{0x33}, which means that bits @code{0}
>  (anonymous private mappings), @code{1} (anonymous shared mappings),
>  @code{4} (ELF headers) and @code{5} (private huge pages) are active.
>  This will cause these memory mappings to be dumped automatically.
> +
> +@kindex set honor-dontdump-flag
> +@anchor{set honor-dontdump-flag}
> +@item set honor-dontdump-flag on
> +@itemx set honor-dontdump-flag off
> +If @code{on} is specified, GDB will not dump memory regions marked
> +with the VM_DONTDUMP flag. This flag is represented in
                            ^^^

Two spaces after period.

I also think 'VM_DONTDUMP' should be marked as @code{}.

> +@file{/proc/@var{pid}/smaps} with the acronym @code{dd}.
> +
> +The default value is @code{on}.
>  @end table
>  
>  @node Character Sets
> -- 
> 2.14.3

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/