This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] C++ify osdata

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Pedro Alves <palves at redhat dot com>
Cc: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
Date: Thu, 23 Nov 2017 21:58:26 -0500
Subject: Re: [PATCH] C++ify osdata
Authentication-results: sourceware.org; auth=none
References: <20171118233827.7418-1-simon.marchi@polymtl.ca> <9d0b9473-1fd5-8310-0cde-8233efed58bc@redhat.com> <19f399ce-dfb9-15fd-41ed-2a4576a438f6@ericsson.com> <4172ddfc-fb35-e7e6-f168-800eabb62b77@redhat.com>

On 2017-11-23 17:46, Pedro Alves wrote:

On 11/23/2017 06:39 PM, Simon Marchi wrote:

On 2017-11-23 07:54 AM, Pedro Alves wrote:

Isn't this leaking the heap-allocated vectors?

Why make it a map of pointers, actually?  Why not:

Oops, thanks for noticing and for the suggestion. I don't know what Iwas thinking.
What about this patch?


LGTM.

Thanks,
Pedro Alves


Thanks, pushed.

Simon

References:
- [PATCH] C++ify osdata
  - From: Simon Marchi
- Re: [PATCH] C++ify osdata
  - From: Pedro Alves
- Re: [PATCH] C++ify osdata
  - From: Simon Marchi
- Re: [PATCH] C++ify osdata
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]